Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: comments repository #486

Merged
merged 8 commits into from
Feb 4, 2024
Merged

refactor: comments repository #486

merged 8 commits into from
Feb 4, 2024

Conversation

7mochi
Copy link
Contributor

@7mochi 7mochi commented Sep 11, 2023

Describe your changes

Related Issues / Projects

Checklist

  • I've manually tested my code
  • The changes pass pre-commit checks (make lint)
  • The changes follow coding style

@7mochi 7mochi added the enhancement New feature or request label Sep 11, 2023
@7mochi 7mochi self-assigned this Sep 11, 2023
@NiceAesth NiceAesth added the code quality Something is implemented poorly label Sep 21, 2023
@7mochi 7mochi mentioned this pull request Sep 21, 2023
17 tasks
@7mochi 7mochi changed the base branch from master to repositories September 21, 2023 13:11
@7mochi 7mochi marked this pull request as draft September 22, 2023 01:30
@7mochi 7mochi changed the base branch from repositories to master September 24, 2023 03:42
@7mochi 7mochi marked this pull request as ready for review September 24, 2023 04:02
app/repositories/comments.py Outdated Show resolved Hide resolved
app/repositories/comments.py Outdated Show resolved Hide resolved


class CommentWithUserPrivileges(Comment):
priv: int
Copy link
Member

@cmyui cmyui Feb 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cursed abstraction but probably better than O(n) db calls & it's non-critical code

@cmyui
Copy link
Member

cmyui commented Feb 4, 2024

tested on local and is working

@cmyui cmyui merged commit e755db1 into master Feb 4, 2024
5 checks passed
@cmyui cmyui deleted the comments-repo branch February 4, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Something is implemented poorly enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants