refactor: ratings repository #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7mochi
added
enhancement
7mochi
requested review from
cmyui,
skrungly,
NiceAesth and
tsunyoku
as code owners
cmyui
requested changes
Feb 14, 2024
app/repositories/ratings.py
Outdated
| return cast(Rating, dict(_rating._mapping)) | ||
|
|
||
|
|
||
| async def fetch_all(map_md5: str) -> list[Rating]: |
There was a problem hiding this comment.
This can be a bit more flexible - we can make it fetch_many which allows for optional pagination, map md5 as an optional filter as well as an optional user id filter
|
Made some changes -- condensed diff here: https://github.com/osuAkatsuki/bancho.py/pull/599/files/d3133736434027c6dcd4117fddead922c28e905b..f2eed79d3ab034f3055cc0300671ec46bcecfe70 |
cmyui
force-pushed
the
map_ratings_repo
branch
from
67db503
to
f2eed79
Compare
|
There is also bancho.py/app/objects/beatmap.py Line 546 in fdb6cb6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Related Issues / Projects
Checklist