Refactor osu!direct handlers #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsunyoku
commented
Apr 1, 2024
|
|
||
|
|
||
| async def download_map(set_id: str = Path(...)): | ||
| domain = config.DIRECT_URL.split("/")[2] |
There was a problem hiding this comment.
this one gave me anxiety because any direct URL that has more than a single path prefix (/) would literally not work
for more information, see https://pre-commit.ci
cmyui
approved these changes
Apr 14, 2024
|
Completed in more recent PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was mostly reading the source to figure out the work required to migrate
score-serviceto useBeatmapsServicebut realised it was a mess... A la refactorA couple specializations are removed here, but I think this is for the best - standardisation is something I'm trying to achieve and already done so on hanayo.