Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor osu!direct handlers #81

Closed
wants to merge 5 commits into from
Closed

Refactor osu!direct handlers #81

wants to merge 5 commits into from

Conversation

tsunyoku
Copy link

@tsunyoku tsunyoku commented Apr 1, 2024

Was mostly reading the source to figure out the work required to migrate score-service to use BeatmapsService but realised it was a mess... A la refactor

A couple specializations are removed here, but I think this is for the best - standardisation is something I'm trying to achieve and already done so on hanayo.



async def download_map(set_id: str = Path(...)):
domain = config.DIRECT_URL.split("/")[2]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one gave me anxiety because any direct URL that has more than a single path prefix (/) would literally not work

@cmyui
Copy link
Member

cmyui commented Jun 24, 2024

Completed in more recent PRs

@cmyui cmyui closed this Jun 24, 2024
@cmyui cmyui deleted the unfuck-direct branch June 24, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants