Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit slug length #1655

Merged
merged 9 commits into from
Feb 22, 2024
Merged

Limit slug length #1655

merged 9 commits into from
Feb 22, 2024

Conversation

SebouChu
Copy link
Member

@SebouChu SebouChu commented Feb 22, 2024 •
edited
Loading

WIP #1651

  • Limite de 100 caractères aux slugs (back + js)
  • Refactor de l'input slug
  • Ajout de l'input slug aux diplômes et aux publications
  • On sort la partie path de Sluggable pour la mettre dans un concern Pathable

@SebouChu SebouChu requested a review from pabois February 22, 2024 14:28
@SebouChu SebouChu merged commit 7743e64 into main Feb 22, 2024
6 checks passed
@SebouChu SebouChu deleted the limit-slug-size branch February 22, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabois pabois pabois approved these changes

@arnaudlevy arnaudlevy Awaiting requested review from arnaudlevy arnaudlevy is a code owner

@alexisben alexisben Awaiting requested review from alexisben alexisben is a code owner

@Olivia206 Olivia206 Awaiting requested review from Olivia206 Olivia206 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SebouChu @pabois