Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redirect to "/" instead of root_path to be clear and handle activestorage #1688

Merged
merged 2 commits into from
Mar 6, 2024
Merged

redirect to "/" instead of root_path to be clear and handle activestorage #1688

merged 2 commits into from
Mar 6, 2024

Conversation

SebouChu
Copy link
Member

@SebouChu SebouChu commented Mar 6, 2024

C'était ça ou override dans ActiveStorage::BaseController mais je trouve ça + clean comme ça

@SebouChu SebouChu mentioned this pull request Mar 6, 2024
Closed
@SebouChu SebouChu linked an issue Mar 6, 2024 that may be closed by this pull request
NameError in active_storage/direct_uploads#create #1687
Closed
arnaudlevy
arnaudlevy approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@arnaudlevy arnaudlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je comprends pas mais je suis d'accord :)

@SebouChu SebouChu merged commit 0420fc1 into main Mar 6, 2024
6 checks passed
@SebouChu SebouChu deleted the fix_handle_unverified_request branch March 6, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlevy arnaudlevy arnaudlevy approved these changes

@pabois pabois Awaiting requested review from pabois pabois is a code owner

@alexisben alexisben Awaiting requested review from alexisben alexisben is a code owner

@Olivia206 Olivia206 Awaiting requested review from Olivia206 Olivia206 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NameError in active_storage/direct_uploads#create
2 participants
@SebouChu @arnaudlevy