Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renforcement de la sécurité #1779

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Renforcement de la sécurité #1779

merged 5 commits into from
Apr 18, 2024

Conversation

arnaudlevy
Copy link
Member

Fix #1777
Fix #1778

@arnaudlevy
Copy link
Member Author

@SebouChu pas sûr du tout que ça résolve le #1778

SebouChu
SebouChu approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@SebouChu SebouChu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ça fix bien l'issue 1, pour l'autre, je trouve que c'est un faux positif, on envoie une URL au service de screen qui nous renvoie forcément un truc clean, c'est pas du user input

@SebouChu SebouChu merged commit b29f89a into main Apr 18, 2024
5 checks passed
@SebouChu SebouChu deleted the screenshot-security branch April 18, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebouChu SebouChu SebouChu approved these changes

@pabois pabois Awaiting requested review from pabois pabois is a code owner

@alexisben alexisben Awaiting requested review from alexisben alexisben is a code owner

@Olivia206 Olivia206 Awaiting requested review from Olivia206 Olivia206 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@arnaudlevy @SebouChu