Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external to blocks links statics #1936

Merged
merged 5 commits into from
May 28, 2024
Merged

Conversation

pabois
Copy link
Member

@pabois pabois commented May 28, 2024

No description provided.

@pabois pabois merged commit 91f0904 into main May 28, 2024
5 checks passed
@pabois pabois deleted the add_external_to_blocks_links_statics branch May 28, 2024 16:04
@arnaudlevy
Copy link
Member

Ben il est très bizarre ton code @pabois ! C'était bien de faire le calcul dans le model !

@pabois
Copy link
Member Author

pabois commented May 28, 2024

j'ai besoin du contexte du @website. Donc à moins de faire du passe-plat dans les modèles (ce que je voyais pas trop comment faire avec tes helpers metaprogrammés).
J'ai fait simple

@arnaudlevy
Copy link
Member

Ah ok !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants