Rubocop and other updates/fixes for TK #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for our self signed testing cert to be verified properly by ruby. New code was added to the openstack-identity cookbook which required this to work in TK.
knightsamar
suggested changes
Jan 14, 2017
|
@knightsamar that should be fixed now. Thanks for catching that! |
knightsamar
reviewed
Jan 18, 2017
| @@ -2,6 +2,7 @@ | |||
| "env_run_lists": {}, | |||
| "run_list": [ | |||
| "recipe[openstack_test::hosts]", | |||
| "recipe[openstack_test::cacert]", | |||
There was a problem hiding this comment.
Where exactly is this cookbook openstack_test ?
There was a problem hiding this comment.
Test kitchen works well btw 👍
There was a problem hiding this comment.
@knightsamar it's in the cookbook, look at Berksfile to see where exactly
There was a problem hiding this comment.
Thanks. This is an interesting setup. Hopefully I can make time to read the code and understand how you are making these things work.
knightsamar
approved these changes
Jan 18, 2017
|
!bump patch * |
|
Jenkins has merged this PR into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.