Add partials views and client views #103

alxngyn · 2016-06-27T22:30:29Z

PR 1 of 3: clients
Related issue: #102
This is a prototype view of the clients endpoint.

Changes in this PR.

Client View for CREATE, EDIT, INDEX (list view), SHOW(detailed view)
Partial views for headers and footers in /views
No delete view implemented as I was running into ForeignConstraint Restrictions and still need to figure out the model issue(if we need should even be deleting things)
delete now soft deletes and hides the client from the list view

Testing this PR.

sudo docker-compose run --service-ports dev bash
run rake migrate to setup the DB schema
Generate data with this code: (copy and paste it into a temp rb file and run it)

require './environment.rb'
require 'models'

# generate data
 (0...25).each do
   o = [('a'..'z'), ('A'..'Z')].map(&:to_a).flatten
   name = (0...10).map { o[rand(o.length)] }.join

   new_client = Client.create(name:  name,
                              contact_name:  'bob',
                              contact_email:  'bob@example.com',
                              description:  'blah')

   name = (0...10).map { o[rand(o.length)] }.join

   new_project = Project.create(name: name,
                                client_id: 1 + rand(new_client.id),
                                resources: 'node,thingy',
                                description: 'blah')

   name = (0...10).map { o[rand(o.length)] }.join

   NodeResource.create(project_id: 1 + rand(new_project.id),
                       name: name,
                       type: 'ganeti',
                       cluster: 'cluster1.osuosl.org',
                       created: DateTime.now,
                       modified: DateTime.now)
 end

In a web browser, go to http://localhost:4567/clients
Try clicking on the client name, the edit button, using the edit form, etc

Expected Output.

n/a

alxngyn · 2016-06-27T22:31:39Z

blocked by #87
The patch and delete methods needs method_override to be enabled to function properly
EDIT: #87 merged.

alxngyn · 2016-06-28T18:40:04Z

Screenshots of the views:
Edit:

Show:

Create:

Index:

pop · 2016-06-28T19:02:09Z

@alxngyn How did you populate the DB with dummy data? The script keeps breaking (as you point out it will).

alxngyn · 2016-06-28T19:28:22Z

Did the code not work for you? (I mentioned that the script keeps breaking?)
It should work if you put it into a file on the same directory level as app.rb.

pop · 2016-06-28T19:35:15Z

@alxngyn This looks like the error you were describing in the last checkbox for this PR. I mis-interpreted what you meant by that, but the point still stands.

[root@aa55c89eb34a code]# ruby tmp.rb                                                                                                                         
/usr/local/lib/ruby/gems/2.3.0/gems/sequel-4.33.0/lib/sequel/model/base.rb:2181:in `block in set_restricted': method name= doesn't exist (Sequel::MassAssignmentRestriction)
        from /usr/local/lib/ruby/gems/2.3.0/gems/sequel-4.33.0/lib/sequel/model/base.rb:2168:in `each'
        from /usr/local/lib/ruby/gems/2.3.0/gems/sequel-4.33.0/lib/sequel/model/base.rb:2168:in `set_restricted'
        from /usr/local/lib/ruby/gems/2.3.0/gems/sequel-4.33.0/lib/sequel/model/base.rb:1597:in `set'
        from /usr/local/lib/ruby/gems/2.3.0/gems/sequel-4.33.0/lib/sequel/model/base.rb:2124:in `initialize_set'
        from /usr/local/lib/ruby/gems/2.3.0/gems/sequel-4.33.0/lib/sequel/model/base.rb:1199:in `initialize'
        from /usr/local/lib/ruby/gems/2.3.0/gems/sequel-4.33.0/lib/sequel/model/base.rb:170:in `new'
        from /usr/local/lib/ruby/gems/2.3.0/gems/sequel-4.33.0/lib/sequel/model/base.rb:170:in `create'
        from tmp.rb:9:in `block in <main>'
        from tmp.rb:5:in `each'
        from tmp.rb:5:in `<main>'

alxngyn · 2016-06-28T20:28:52Z

@ElijahCaine Oops my fault, you need to run rake migrate before running that script to get the DB schema setup. I'll add it to the PR testing steps.

pop · 2016-06-28T20:37:59Z

views/clients/index.erb

+              <th>Client Name</th>
+              <th>Contact Name</th>
+							<th>Contact Email</th>


What's up with the spacing here?

pop · 2016-06-28T20:41:54Z

@alxngyn Feedback:

Can we add an 'edit' button to each client page? I don't like that I have to go to /clients/ to edit a client.
Can we test these views? We don't necessarily need to, but it'd be nice to have something automatic that checks what we're creating.

All-in-all this PR is awesome. Bootstrap is a good choice, it's very easy to navigate. Once we finish all of the endpoints there might be some polish to make it even more user-friendly, but right now I'm just impressed.

+1

alxngyn · 2016-06-28T21:12:56Z

@ElijahCaine
I believe I can make a tests to make sure each route implements the correct .erb file but I don't think it gets any deeper than that. I'll look into it and implement what I find.

pop · 2016-06-28T23:08:16Z

@alxngyn Awesome. The OSL doesn't really do any automated browser testing, and it isn't entirely necessary for this project, but that may also be something to explore.

But like... don't worry about it too much. Any testing is just better than no testing.

pop · 2016-07-01T21:24:42Z

Added needs work label b/c there's no delete tests / we need to figure out how to deal with deleting stuff. (As per the un-checked checkbox in the PR)

alxngyn · 2016-07-06T20:18:44Z

@ElijahCaine
Should we be deleting stuff?I feel as a metrics webapp the more data the better. Even if they are no longer a client or project we should still store the data.

Kennric · 2016-07-07T23:22:53Z

I think rather than having a delete functionality, we should have an active flag and be able to turn clients (and projects) 'off' for purposes of viewing them in the interface

alxngyn · 2016-07-07T23:44:09Z

@Kennric
I agree.
Should i change all the models so they have an active flag? (clients, projects, plugins, node_resources)

alxngyn · 2016-08-18T21:54:52Z

now that #131 is merged into develop. I can rework the views to 'hide' the data if the active flag is turned off.

hsolorza · 2016-08-18T23:37:59Z

views/clients/show.erb

+            </tr>
+          </thead>
+          <tbody>
+						<% for @project in @projects %>


Whitespace problems here too

…client-view Conflicts: routes/clients.rb

alxngyn · 2016-08-19T23:13:33Z

I reworked the views/routing to incorporate the active flags now

hsolorza · 2016-08-22T17:57:21Z

views/clients/show.erb

+          <thead>
+            <tr>
+              <th>id</th>
+              <th>project Name</th>


Project should be capitalized

hsolorza · 2016-08-22T20:31:00Z

@alxngyn What are the 'link link link..' in the footer going to be linking to? Should they have a name?

alxngyn · 2016-08-22T21:07:16Z

@hsolorza those are just place holders for now. I don't think we had any feedback or requirements on the header/footer stuff yet.

hsolorza · 2016-08-22T21:07:58Z

Everything looks good +1

Kennric · 2016-08-22T23:19:03Z

Are there still whitespace issues in views?

alxngyn · 2016-08-22T23:43:20Z

@Kennric Only took 4 commits but i fixed the white space and it should show up fixed on Github

pop · 2016-08-23T21:09:56Z

This is a good start, but we'll need to do some serious cleanup with @subnomo to get this to be usable. It's still pretty rough around the edges.
+1 we can merge this.

Added partials views and client views

262e4f3

alxngyn added Ready for Review Blocked labels Jun 27, 2016

fixed href link and removed env configs in app.rb

65dc6af

pop reviewed Jun 28, 2016
View reviewed changes

views/clients/index.erb

<th>Client Name</th>

<th>Contact Name</th>

<th>Contact Email</th>

Copy link

Contributor

pop Jun 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with the spacing here?

Added edit link and spec tests for client

9681142

pop added Needs Work and removed Blocked labels Jul 1, 2016

alxngyn mentioned this pull request Jul 7, 2016

Client, project and node views #102

Closed

alxngyn mentioned this pull request Jul 8, 2016

create active flag for each of the models #118

Closed

alxngyn self-assigned this Aug 4, 2016

hsolorza added this to the Sprint for 08/18 milestone Aug 11, 2016

pop removed the Ready for Review label Aug 16, 2016

athai added Needs Work and removed Needs Work labels Aug 18, 2016

hsolorza reviewed Aug 18, 2016
View reviewed changes

views/clients/show.erb

</tr>

</thead>

<tbody>

<% for @project in @projects %>

Copy link

Contributor

hsolorza Aug 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace problems here too

alxngyn added 3 commits August 19, 2016 14:36

Merge branch 'develop' of https://github.com/osuosl/iam into alxngyn/…

3b8791a

…client-view Conflicts: routes/clients.rb

updated client views/routes for active flags

8c8ccd2

fixed clients GET ID logic

cfd678e

alxngyn added Ready for Review and removed Needs Work labels Aug 19, 2016

hsolorza reviewed Aug 22, 2016
View reviewed changes

views/clients/show.erb

<thead>

<tr>

<th>id</th>

<th>project Name</th>

Copy link

Contributor

hsolorza Aug 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project should be capitalized

Capitalized project

e6e506d

alxngyn and others added 4 commits August 22, 2016 16:31

Fixed white space issue on clients/index.erb

512cca9

i think i fixed the white space issue?

cb8367a

I swear i fixed the whitespace before

4fdb438

fixed whitespace finale

5938112

alxngyn merged commit e5560da into develop Aug 24, 2016

Kennric deleted the alxngyn/client-view branch June 20, 2017 21:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add partials views and client views #103

Add partials views and client views #103

alxngyn commented Jun 27, 2016 •

edited

alxngyn commented Jun 27, 2016 •

edited

alxngyn commented Jun 28, 2016

pop commented Jun 28, 2016

alxngyn commented Jun 28, 2016

pop commented Jun 28, 2016 •

edited

alxngyn commented Jun 28, 2016

pop Jun 28, 2016

pop commented Jun 28, 2016

alxngyn commented Jun 28, 2016

pop commented Jun 28, 2016 •

edited

pop commented Jul 1, 2016 •

edited

alxngyn commented Jul 6, 2016

Kennric commented Jul 7, 2016

alxngyn commented Jul 7, 2016

alxngyn commented Aug 18, 2016

hsolorza Aug 18, 2016

alxngyn commented Aug 19, 2016

hsolorza Aug 22, 2016

hsolorza commented Aug 22, 2016 •

edited

alxngyn commented Aug 22, 2016

hsolorza commented Aug 22, 2016

Kennric commented Aug 22, 2016

alxngyn commented Aug 22, 2016

pop commented Aug 23, 2016 •

edited

Add partials views and client views #103

Add partials views and client views #103

Conversation

alxngyn commented Jun 27, 2016 • edited

Changes in this PR.

Testing this PR.

Expected Output.

alxngyn commented Jun 27, 2016 • edited

alxngyn commented Jun 28, 2016

pop commented Jun 28, 2016

alxngyn commented Jun 28, 2016

pop commented Jun 28, 2016 • edited

alxngyn commented Jun 28, 2016

pop Jun 28, 2016

Choose a reason for hiding this comment

pop commented Jun 28, 2016

alxngyn commented Jun 28, 2016

pop commented Jun 28, 2016 • edited

pop commented Jul 1, 2016 • edited

alxngyn commented Jul 6, 2016

Kennric commented Jul 7, 2016

alxngyn commented Jul 7, 2016

alxngyn commented Aug 18, 2016

hsolorza Aug 18, 2016

Choose a reason for hiding this comment

alxngyn commented Aug 19, 2016

hsolorza Aug 22, 2016

Choose a reason for hiding this comment

hsolorza commented Aug 22, 2016 • edited

alxngyn commented Aug 22, 2016

hsolorza commented Aug 22, 2016

Kennric commented Aug 22, 2016

alxngyn commented Aug 22, 2016

pop commented Aug 23, 2016 • edited

alxngyn commented Jun 27, 2016 •

edited

alxngyn commented Jun 27, 2016 •

edited

pop commented Jun 28, 2016 •

edited

pop commented Jun 28, 2016 •

edited

pop commented Jul 1, 2016 •

edited

hsolorza commented Aug 22, 2016 •

edited

pop commented Aug 23, 2016 •

edited