Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POWERDev page from old site #135

Merged
merged 5 commits into from
Feb 24, 2017
Merged

Conversation

knightsamar
Copy link
Contributor

@knightsamar knightsamar commented Feb 22, 2017

Works towards resolving #128 by adding CSV-powered tables containing list of POWERDev related projects

  • Fix location and text for the menu item for POWERDev to make it look like the old one
  • Separating RST and CSV by putting csv files inside a subdirectory of the content
  • Academic Partners
  • Hosted open source projects
  • Odd-even styling for rows - odd even row coloring for powerdev dougfir-pelican-theme#77

@ramereth
Copy link
Member

@knightsamar this PR should contain the submodule update from osuosl/dougfir-pelican-theme#77 once that's merged.

Copy link
Member

@ramereth ramereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend we go ahead and merge this as-is w/o the css table update. It's more important to get this back on the site than to make sure it looks 100% the same as before.

@knightsamar can you please also create a new PR which includes any missing projects? I wasn't sure if this included any new projects.

@knightsamar
Copy link
Contributor Author

knightsamar commented Feb 24, 2017

@ramereth , could you please review the pruned project and academic partner list? Sorry, I noticed your comment after pushing. I can move the commits to another PR if required.

This list is now created by cross-referencing IBM's spreadsheet with openstack project list and it should present the most accurate picture of what we actually hosting.

I also propose that we have a page/list for projects which were hosted before with us but now have moved on because of their success and/or requirements for more hardware like GATK, GLIBC.

Copy link
Member

@ramereth ramereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knightsamar there seems to be an issue with the CSV data in powerdev_open_source_projects.csv.

/home/lance/git/osl/osuosl-pelican/content/services/services_powerdev.rst:46: (ERROR/3) Error with CSV data in "csv-table" directive:
',' expected after '"'

@knightsamar knightsamar force-pushed the samarendra/powerdev_page_from_old_site branch from d7b0c27 to bcf0efd Compare February 24, 2017 17:47
@knightsamar
Copy link
Contributor Author

@ramereth thanks for catching that! fixed and rebased.

Copy link
Member

@ramereth ramereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I agree that we should make a separate PR that lists "Past projects" so we show the history.

@knightsamar
Copy link
Contributor Author

!bump patch ~

@ramereth ramereth merged commit 1e7469f into master Feb 24, 2017
@ramereth ramereth deleted the samarendra/powerdev_page_from_old_site branch February 24, 2017 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants