Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New method Configuration.merge(Configuration other) #85

Closed
6 tasks done
oswaldobapvicjr opened this issue Jul 10, 2022 · 0 comments · Fixed by #86
Closed
6 tasks done

New method Configuration.merge(Configuration other) #85

oswaldobapvicjr opened this issue Jul 10, 2022 · 0 comments · Fixed by #86
Assignees
@oswaldobapvicjr
Labels
2.x The target Confectory version enhancement New feature or request

Comments

@oswaldobapvicjr
Copy link
Owner

oswaldobapvicjr commented Jul 10, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

No

Describe the solution you'd like

Add a new merge method into the existing Configuration class, so that users may perform configuration merge without understanding the framework's internals.

The new method may delegate to the one of the recently introduced ConfigurationMerger. The available ConfigurationHelper can be used to instantiate the correct merger object for the current Configuration setup:

  • PropertiesConfigurationMerger
  • JSONObjectConfigurationMerger
  • JsonOrgConfigurationMerger
  • GsonJsonObjectConfigurationMerger
  • JacksonJsonNodeConfigurationMerger
  • JUnit tests

Note: Advanced parameters currently available for JSON merging (distinct keys) shall be supported only in a future phase.

Describe alternatives you've considered

Advanced users may still consider using the ConfigurationMerger classes for fine settings.

Additional context

N/A
@oswaldobapvicjr oswaldobapvicjr self-assigned this Jul 10, 2022
@oswaldobapvicjr oswaldobapvicjr added enhancement New feature or request 2.x The target Confectory version labels Jul 10, 2022
@oswaldobapvicjr oswaldobapvicjr linked a pull request Jul 10, 2022 that will close this issue
New method Configuration.merge(Configuration other) (#85) #86
Merged
oswaldobapvicjr added a commit that referenced this issue Jul 10, 2022
@oswaldobapvicjr
New method Configuration.merge(Configuration other) (#85) (#86)
ee1f796 
* New JSON Configuration Merger bridge for the Jackson provider

* Update JacksonJsonNodeConfigurationMerger.java

* New method Configuration.merge(Configuration other)

* Fix Javadocs

* Add missing JUnit tests and Javadocs

* Add missing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oswaldobapvicjr oswaldobapvicjr

Labels
2.x The target Confectory version enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New method Configuration.merge(Configuration other) (#85) oswaldobapvicjr/confectory
1 participant
@oswaldobapvicjr