Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DataFetchStrategy.LENIENT as default #108

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Conversation

oswaldobapvicjr
Copy link
Owner

@oswaldobapvicjr oswaldobapvicjr commented Jan 11, 2023

Issue

  • The TypeSafeConfigurationContainer does not allow overwriting the default DataFetchStrategy (which is hardcoded as STRICT, but not very well aligned with the usability and purpose of this type of container.

Proposal

  • The default DataFetchStrategy form Confectory.settings() should be considered by the TypeSafeConfigurationContainer
  • Optionally, the user should be able to define a different strategy on TypeSafeConfigurationContainer construction
  • The LENIENT DataFetchStrategy is better aligned with the purpose of all types of containers, so it should be the initial default strategy

@oswaldobapvicjr oswaldobapvicjr added enhancement New feature or request 2.x The target Confectory version labels Jan 11, 2023
@oswaldobapvicjr oswaldobapvicjr self-assigned this Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #108 (4a3b674) into master (d991487) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #108   +/-   ##
=========================================
  Coverage     99.16%   99.16%           
- Complexity      384      385    +1     
=========================================
  Files            63       63           
  Lines           717      721    +4     
  Branches         51       51           
=========================================
+ Hits            711      715    +4     
  Misses            5        5           
  Partials          1        1           
Impacted Files Coverage Δ
...va/net/obvj/confectory/ConfigurationContainer.java 100.00% <ø> (ø)
...in/java/net/obvj/confectory/DataFetchStrategy.java 100.00% <100.00%> (ø)
...bvj/confectory/TypeSafeConfigurationContainer.java 100.00% <100.00%> (ø)
...t/obvj/confectory/settings/ConfectorySettings.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@oswaldobapvicjr oswaldobapvicjr merged commit 18dd27c into master Jan 11, 2023
@oswaldobapvicjr oswaldobapvicjr deleted the issue/0108 branch January 11, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x The target Confectory version enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant