Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New JSONObjectConfigurationMerger implementation #77

Merged
merged 9 commits into from
Apr 18, 2022
Merged

Conversation

oswaldobapvicjr
Copy link
Owner

No description provided.

@oswaldobapvicjr oswaldobapvicjr self-assigned this Mar 16, 2022
@oswaldobapvicjr oswaldobapvicjr added enhancement New feature or request 2.x The target Confectory version labels Mar 16, 2022
@oswaldobapvicjr oswaldobapvicjr linked an issue Mar 16, 2022 that may be closed by this pull request
4 tasks
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #77 (b2cc9c6) into master (a85ceac) will decrease coverage by 0.02%.
The diff coverage is 98.93%.

@@             Coverage Diff              @@
##             master      #77      +/-   ##
============================================
- Coverage     99.11%   99.08%   -0.03%     
- Complexity      362      384      +22     
============================================
  Files            57       59       +2     
  Lines           677      769      +92     
  Branches         51       64      +13     
============================================
+ Hits            671      762      +91     
  Misses            5        5              
- Partials          1        2       +1     
Impacted Files Coverage Δ
...nfectory/merger/JSONObjectConfigurationMerger.java 98.52% <98.52%> (ø)
...confectory/merger/AbstractConfigurationMerger.java 100.00% <100.00%> (ø)
...nfectory/merger/PropertiesConfigurationMerger.java 100.00% <100.00%> (ø)
...a/net/obvj/confectory/util/JsonPathExpression.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a85ceac...b2cc9c6. Read the comment docs.

@oswaldobapvicjr oswaldobapvicjr merged commit ce7f9a5 into master Apr 18, 2022
@oswaldobapvicjr oswaldobapvicjr deleted the issue/0020 branch April 18, 2022 02:57
@oswaldobapvicjr
Copy link
Owner Author

Accepted even with the coverage reduction reported by Codecov. The Coverage reduction of 0.03% is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x The target Confectory version enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[confectory-core] New JSONObjectConfigurationMerger
1 participant