fix(EXCEPTIONS): inherit from proper class

osx-provisioner · Jun 17, 2022 · 6bcacf4 · 6bcacf4
1 parent 4e5b9b7
commit 6bcacf4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/mac_maker/utilities/github.py b/mac_maker/utilities/github.py
@@ -11,7 +11,7 @@
 from .. import config
 
 
-class InvalidGithubRepository(BaseException):
+class InvalidGithubRepository(Exception):
   """Raised when a Github repository URL cannot be parsed."""
 
 

diff --git a/mac_maker/utilities/validation/precheck.py b/mac_maker/utilities/validation/precheck.py
@@ -23,7 +23,7 @@ class TypePrecheckVariableDefinition(TypedDict):
   description: str
 
 
-class PrecheckConfigValidationException(BaseException):
+class PrecheckConfigValidationException(Exception):
   """Raised when reading an invalid Precheck environment configuration file."""
 
 

diff --git a/mac_maker/utilities/validation/spec.py b/mac_maker/utilities/validation/spec.py
@@ -19,7 +19,7 @@ class TypeSpecFileData(TypedDict):
   spec_file_location: Union[Path, str]
 
 
-class SpecFileValidationException(BaseException):
+class SpecFileValidationException(Exception):
   """Raised when reading an invalid Job Spec file."""