Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom user normalization & verbose flag for LICs #68

Merged
merged 84 commits into from
Feb 10, 2022

Conversation

Adnan-Ali-Ahmad
Copy link
Collaborator

  • Added verbose flag to LIC wrapper
  • Added string check when plot::parse_layer parses the "norm" keyword, so that users can provide their own custom normalization instead of being constrained to the ones in get_norm.
  • Added "SymLog" to get_norm, which plots simultaneously negative & positive in logarithmic scaling (eg. for radial velocities, or B_field components). Below is an example of this:
    image

Copy link
Collaborator

@nvaytet nvaytet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments.

Can you change the PR title to something that describes the changes a little better, then I can use this when making a release, as github will generate release notes automatically from PR titles ;-)

src/osyris/plot/wrappers.py Show resolved Hide resolved
src/osyris/plot/parser.py Outdated Show resolved Hide resolved
src/osyris/plot/parser.py Outdated Show resolved Hide resolved
@Adnan-Ali-Ahmad Adnan-Ali-Ahmad changed the title Minor changes 2 Custom user normalization & verbose flag for LICs Feb 9, 2022
src/osyris/plot/parser.py Show resolved Hide resolved
@nvaytet nvaytet merged commit aedab72 into osyris-project:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants