Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support schema merging #237

Merged
merged 5 commits into from
Jul 29, 2023

Conversation

MarcRoemmelt
Copy link
Contributor

Hi! Here the PR :)

Implements the new rule option mergeSchemas:

{
  "mergeSchemas": ["$schema", "options", "catalog"] // or true as shorthand for all three
}

Schemas will be validated as logical AND, meaning all of them must be satisfied.

  • Documentation updated
  • Test cases added

Would be great to see this merged! If you would want any changes, please let me know.

Closes #235

This option controlls whether schemas from different sources are merged and combined together.
Can be an array of ["$schema", "options", "catalog"] or true as shorthand for all three.

Closes ota-meshi#235
@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2023

🦋 Changeset detected

Latest commit: 1e05c90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-json-schema-validator Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Owner

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit c5ddb60 into ota-meshi:main Jul 29, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support extending $schema with plugin options
2 participants