Fixed crash for v flag in regexp/optimal-quantifier-concatenation (#…

…660) * fix: crash for v flag in `regexp/optimal-quantifier-concatenation` * Create chilly-pumpkins-raise.md * Update lib/rules/optimal-quantifier-concatenation.ts Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com> * fix --------- Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
ota-meshi · Oct 20, 2023 · 542c39d · 542c39d
1 parent 669b239
commit 542c39d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/chilly-pumpkins-raise.md b/.changeset/chilly-pumpkins-raise.md
@@ -0,0 +1,5 @@
+---
+"eslint-plugin-regexp": patch
+---
+
+Fixed crash for v flag in `regexp/optimal-quantifier-concatenation`
diff --git a/lib/rules/optimal-quantifier-concatenation.ts b/lib/rules/optimal-quantifier-concatenation.ts
@@ -64,7 +64,8 @@ function getSingleConsumedChar(
     element: Element | Alternative,
     flags: ReadonlyFlags,
 ): SingleConsumedChar {
-    const empty = flags.unicode ? EMPTY_UNICODE : EMPTY_UTF16
+    const empty =
+        flags.unicode || flags.unicodeSets ? EMPTY_UNICODE : EMPTY_UTF16
 
     switch (element.type) {
         case "Alternative":

diff --git a/tests/lib/rules/optimal-quantifier-concatenation.ts b/tests/lib/rules/optimal-quantifier-concatenation.ts
@@ -25,6 +25,7 @@ tester.run("optimal-quantifier-concatenation", rule as any, {
         },
         String.raw`/^(?:\[\[\[?.+?\]?\]\]|<<.+?>>)$/`,
         String.raw`/a\s*?(?=\r?\n|\r)/`,
+        String.raw`/(?:a|b)?c/v`,
     ],
     invalid: [
         {