Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
refa
,regex-ast-analysis
, andscslre
.There are a lot of changes in both refa and RAA because of the
v
flag, so fixing all errors will be fun... I also had to change the semantics of a few common functions in RAA. Noteably,is{Potentially,}{Empty,ZeroLength}
and a few others now require a flags argument. (Since we can't assume that a single character class/set is a single character anymore, we have to evaluate the whole thing in some cases, and that requires flags.)This PR is still a work in progress. Since some type errors are caused by the algorithm fundamentally assuming a single character, I will liberally use
// @ts-expect-error -- FIXME
for now.