Add regexp/prefer-set-operation
rule
#616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #581.
The implementation of the rule is fairly simple right now. It just goes through all elements of an alternative and tries to find the pattern
(?=a)b
ora(?<=b)
. So it won't attempt to do clever things like assertions reordering (e.g.(?!a)(?=bcd)e
==(?=bcd)(?!a)e
==(?=bcd)[e--a]
) and partial application (e.g.(?!a|bcd)e
==(?!bcd)(?!a)e
==(?!bcd)[e--a]
). I think it should be okay. Adjacent assertions are rare in practice, and partial application has the issue that it might make the intent of the author less clear.