Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Intl.Segmenter instead of grapheme-splitter #642

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Conversation

ota-meshi
Copy link
Owner

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023

🦋 Changeset detected

Latest commit: a35ec0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-regexp Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RunDevelopment
Copy link
Collaborator

Firefox doesn't support Intl.Segmenter, so this will likely break the playground on our website on Firefox. There is a polyfill, but it uses WASM, which might be difficult to integrate it (especially since WASM loads asynchronously). They plan to add support for it soon-ish though ("We're planning this for Q4").

@ota-meshi
Copy link
Owner Author

Thank you for letting me know that! I fixed the demo to work on FireFox as well using polyfill.

@RunDevelopment RunDevelopment merged commit 40704ed into master Oct 5, 2023
5 checks passed
@RunDevelopment RunDevelopment deleted the segmenter branch October 5, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants