Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to official (and unofficial) TOML lists #156

Closed
epage opened this issue Nov 6, 2023 · 4 comments · Fixed by arp242/toml-test-matrix#5
Closed

Add to official (and unofficial) TOML lists #156

epage opened this issue Nov 6, 2023 · 4 comments · Fixed by arp242/toml-test-matrix#5

Comments

@epage
Copy link

epage commented Nov 6, 2023

I found out about this parser because it was used to close renovatebot/renovate#18668.

It isn't listed:

@ota-meshi
Copy link
Owner

Thanks for the suggestion!
This parser is different from other parsers as its main purpose is to generate an AST. So I think people get confused when this parser is in the same list. What do you think? Do you think it should be added to the list?

@epage
Copy link
Author

epage commented Nov 7, 2023

If this is fully conformant, than I think it'd be worth it since there isn't one for JS (at least on the matrix page). The downside would be the potential for an influx of users making requests for regular TOML parsing needs and I can see that be a reason to not advertise it.

For context, I maintain a TOML parser for Rust and it has two levels to its API, the toml package for high level operations and toml_edit for format-preserving edits. I have both on there.

@ota-meshi
Copy link
Owner

ota-meshi commented Nov 7, 2023

Thank you for your opinion!
I've added it to the official list.
This parser does not have a serializer, so I would like to consider later how to add it to the performance matrix. Therefore, I will leave this issue open.

@epage
Copy link
Author

epage commented Nov 7, 2023

This parser does not have a serializer, so I would like to consider later how to add it to the performance matrix. Therefore, I will leave this issue open.

There are other implementations without the encoder validation on the matrix, like Python's tomllib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants