Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssertionFailedError: Enable Java-behavior for late cause initialisation #19

Closed
wants to merge 1 commit into from
Closed

AssertionFailedError: Enable Java-behavior for late cause initialisation #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/main/java/org/opentest4j/AssertionFailedError.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ public class AssertionFailedError extends AssertionError {

private static final long serialVersionUID = 1L;

private static final Throwable NO_CAUSE = new RuntimeException("no cause indicator");

private final ValueWrapper expected;
private final ValueWrapper actual;

Expand All @@ -51,15 +53,15 @@ public AssertionFailedError() {
* and no expected/actual values.
*/
public AssertionFailedError(String message) {
this(message, null);
this(message, NO_CAUSE);
}

/**
* Constructs an {@code AssertionFailedError} with a message and
* expected/actual values but without a cause.
*/
public AssertionFailedError(String message, Object expected, Object actual) {
this(message, expected, actual, null);
this(message, expected, actual, NO_CAUSE);
}

/**
Expand All @@ -80,7 +82,9 @@ public AssertionFailedError(String message, Object expected, Object actual, Thro

private AssertionFailedError(String message, ValueWrapper expected, ValueWrapper actual, Throwable cause) {
super((message == null || message.trim().length() == 0) ? "" : message);
initCause(cause);
if (cause != NO_CAUSE) {
initCause(cause);
}
this.expected = expected;
this.actual = actual;
}
Expand Down
29 changes: 29 additions & 0 deletions src/test/java/org/opentest4j/AssertionFailedErrorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@
import java.io.ObjectInputStream;
import java.io.ObjectOutputStream;

import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;

/**
* Unit tests for {@link AssertionFailedError}.
Expand All @@ -37,6 +39,33 @@
*/
public class AssertionFailedErrorTests {

@Rule
public ExpectedException expectedException = ExpectedException.none();

@Test
public void undefinedCauseDoesNotInitializeCause() throws Exception {
RuntimeException lateCause = new RuntimeException("lateCause");
new AssertionFailedError().initCause(lateCause);
new AssertionFailedError("my message").initCause(lateCause);
new AssertionFailedError(null, "foo", "bar").initCause(lateCause);
}

@Test
public void cannotReinitializeNullCauseForMessageCauseArgs() throws Exception {
RuntimeException lazyCause = new RuntimeException("cause");

expectedException.expect(IllegalStateException.class);
new AssertionFailedError(null, null).initCause(lazyCause);
}

@Test
public void cannotReinitializeNullCauseForExpectedActualCauseArgs() throws Exception {
RuntimeException lazyCause = new RuntimeException("cause");

expectedException.expect(IllegalStateException.class);
new AssertionFailedError(null, "foo", "bar", null).initCause(lazyCause);
}

@Test
public void nullMessageIsConvertedToEmptyString() {
assertEquals("", new AssertionFailedError().getMessage());
Expand Down