Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrazyDiskInfo shows wrong temperature about my SSD which doesn't have temperature info in S.M.A.R.T #2

Closed
BlueSkyDetector opened this issue Jan 20, 2017 · 3 comments

Comments

@BlueSkyDetector
Copy link
Contributor

My SSD temperature value is wrong value.
crazy_temperature_01

https://github.com/otakuto/CrazyDiskInfo/blob/master/main.cpp#L74
If sk_disk_smart_get_temperature() cannot get temperature info, it returns "-1".
So, it should check the return value.

Same things can happen about sk_disk_smart_get_power_cycle() and sk_disk_smart_get_power_on().

@BlueSkyDetector
Copy link
Contributor Author

I made a workaround fix for this.
But using UINT64_MAX and -DBL_MAX for representing error. It's not good approach.
https://github.com/BlueSkyDetector/CrazyDiskInfo/tree/PR-show_values_as_na_if_it_doesnt_have_values

@otakuto
Copy link
Owner

otakuto commented Jan 22, 2017

Thank you for your report and PR.
Was this issue fixed with this commit?
e8d0940

@BlueSkyDetector
Copy link
Contributor Author

Thank you.
It works nicely.
Now I can get "-- °C" as temperature.
crazy_temperature_02

BTW, there is a part remaining old color as following.
I made another PR for this. #4
crazy_temperature_03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants