add getSenders and getReceivers #93
Conversation
package.json
Outdated
| @@ -29,7 +29,7 @@ | |||
| "tape": "^4.0.0", | |||
| "testling": "^1.7.1", | |||
| "travis-multirunner": "^3.0.0", | |||
| "webrtc-adapter": "^3.4.3" | |||
| "webrtc-adapter": "^6.0.2" | |||
There was a problem hiding this comment.
We've moved a bunch of otalk repos to have adapter as a peer dependency, and I guess didn't get this one yet? Let's do that. @legastero @fippo objections?
There was a problem hiding this comment.
Ignore me, we already did that here, and just moved it from dep to devDep 598f7dd#diff-b9cfc7f2cdf78a7f4b91a753d10865a2
jensengar
force-pushed
the
master
branch
2 times, most recently
from
b7e043c
to
436f8db
Compare
|
I think getSenders and getReceivers is always shimmed by adapter? can we split the travis update into a different PR? |
|
@fippo it is, but since we don't bundle or enforce specific adapter version yet, this would be failsafe against an older version. We can deprecate proxying getRemoteStreams/getLocalStreams in this lib at some point as well. |
|
get*Streams + co are extremly hard to get rid of unfortunately :-( |
|
@fippo you want the proxying of getSenders/Receivers and the travis fix in separate prs? |
|
ah... the .travis.yml here was way older than I expected. LGTM! |
|
If this is good, can someone merge it please? |
|
I can merge and release when I get in in a couple hours.
…On Mon, Dec 4, 2017, 9:14 AM Garrett Jensen ***@***.***> wrote:
If this is good, can someone merge it please?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#93 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAy5dx-jhJUE_TZTjT83BobXZNN-BZ9mks5s8_5AgaJpZM4QvKFe>
.
|
|
Plublished as v8.1.0 |
We have a library that depends on RTCPeerConnection which is calling
getRemoteStreams. This is causing a deprecation warning in ff. Seems reasonable to proxy getSenders/Receivers.