use promise version of API #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdumaine
reviewed
Jun 13, 2018
| this.pc.addStream(stream); | ||
| stream.getTracks().forEach( | ||
| function(track) { | ||
| this.pc.addTrack( |
There was a problem hiding this comment.
IIRC this was problematic in chrome. It only allows calling addTrack once? It's been a while since I used this. @jensengar do you remember?
There was a problem hiding this comment.
i've been using this in production for over a year
There was a problem hiding this comment.
ping? Since I heard (from a random person on the street) you're still using this in production
tgabi333
reviewed
Jun 13, 2018
| self.pc.setRemoteDescription(new RTCSessionDescription(offer), | ||
| self.pc.setRemoteDescription( | ||
| new RTCSessionDescription(offer) | ||
| ).then( | ||
| function () { | ||
| cb(); |
There was a problem hiding this comment.
i think we can just pass cb here
There was a problem hiding this comment.
I find this highly confusing:
.then(cb, cb)
it works because the success has arguments and the error uses the first one but...
|
ping? |
legastero
approved these changes
Jul 3, 2018
xdumaine
approved these changes
Jul 9, 2018
|
publishes as 8.4.0. Now updating simplewebrtc.js to use this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
done using https://github.com/fippo/webrtc-codemods