Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

** Fixes #2907 @incude in sass files #2908

Merged
merged 4 commits into from Feb 7, 2017
Merged

Conversation

ilmoeuro
Copy link
Contributor

@ilmoeuro ilmoeuro commented Feb 1, 2017

** Fixes #2907

@ilmoeuro ilmoeuro added this to the 2017/05 milestone Feb 1, 2017
@@ -581,7 +581,7 @@ div[class*="wi-dock-static-navi"] {

}
.lu-infoContainer {
@incude border(2px,#fff,solid);
@include border(2px,#fff,solid);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should be indented 6 spaces, but was indented 7 spaces
Commas in mixin arguments should be followed by one space
Color literals like #fff should only be used in variable declarations; they should be referred to via variable everywhere else.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix pls, color literals can be ignored now

@@ -73,7 +73,7 @@ body[class^='workspace'] {
margin-top:5px;

.lu-picture-container {
@incude border(2px,#fff,solid);
@include border(2px,#fff,solid);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commas in mixin arguments should be followed by one space
Color literals like #fff should only be used in variable declarations; they should be referred to via variable everywhere else.

Copy link
Member

@jjlankinen jjlankinen Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix pls, color literals can be ignored now

@@ -559,7 +559,7 @@ div[class*="wi-dock-static-navi"] {
.lu-badgeContainer {

.lu-user-picture {
@incude border(2px,#fff,solid);
@include border(2px,#fff,solid);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commas in mixin arguments should be followed by one space
Color literals like #fff should only be used in variable declarations; they should be referred to via variable everywhere else.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix pls, color literals can be ignored now

@jjlankinen jjlankinen merged commit dfa121a into devel Feb 7, 2017
@jjlankinen jjlankinen deleted the BUG-2907-incude-in-sass-files branch October 18, 2019 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants