Don't try to wrap socket "onread" when socket is already closed. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much! I'll get this merged and pushed this weekend! |
|
In the meantime, do you have a test for the issue this is addressing? |
In order to wrap socket._handle.onread, we hook into the server's 'connection' event with the aim of wrapping the onread function before request handling begins. However, it is possible that other 'connection' event handlers will run before ours, and they may close the connection before we get a chance to run. In that case, socket._handle is already gone and there is no longer any onread function for us to wrap, so we just do nothing.
|
I've updated the change with a new test. I think I've followed the style of the other tests but please let me know if anything doesn't look right. Confirmed that the test fails before applying my change, and succeeds afterwards. |
|
Landed in 23ad97a. Thanks for your help! It's amazing how careful you have to be in so few lines of code. Also: I apologize for sitting on this for so long. It completely slipped my mind! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to wrap socket._handle.onread, we hook into the server's 'connection' event with the aim of wrapping the onread function before request handling begins.
However, it is possible that other 'connection' event handlers will run before ours, and they may close the connection before we get a chance to run. In that case, socket._handle is already gone and there is no
longer any onread function for us to wrap, so we just do nothing.
I believe this resolves issue #13.