Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to preserve special files #78

Closed
pmhahn opened this issue May 2, 2022 · 2 comments · Fixed by #84
Closed

Option to preserve special files #78

pmhahn opened this issue May 2, 2022 · 2 comments · Fixed by #84
Assignees

Comments

@pmhahn
Copy link

pmhahn commented May 2, 2022

Similar to rsync --specials an option to handle special files as special is required: Currently the code tries to always copy the content of such files, e.g. /dev/console, pipes, sockets, … instead of copying it as a special files.
This is causing kaniko to stall when building base images: GoogleContainerTools/kaniko#960

@otiai10
Copy link
Owner

otiai10 commented May 30, 2022

Couldn't take time to think about the best arch on this.
For quick workaround, you can use Skip option.
Still open and I'm wiling to tackle this issue.

@pmhahn
Copy link
Author

pmhahn commented Jun 4, 2022

Couldn't take time to think about the best arch on this. For quick workaround, you can use Skip option.

Skip only solves half of the problem, namely that you do not fill up all space by copying the content.
But you still need to create the /dev/console special file using man:mknod(1).
And it does not scale to kaniko because there you do not have a static list of files, but just a user-supplied hierarchy of files.

Still open and I'm wiling to tackle this issue.

Thank you for this and your previous work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants