Update functioncall.go

[Naist4869]

support array

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (db9573c) 79.48% compared to head (187a75b) 79.48%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   79.48%   79.48%           
=======================================
  Files           6        6           
  Lines         312      312           
=======================================
  Hits          248      248           
  Misses         45       45           
  Partials       19       19           

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

[otiai10]

@Naist4869 Thank you always for your catch!

[otiai10]

This kind of condition handling should be inside MarshalJSON of Param itself.

[Naist4869]

func (p Param) MarshalJSON() ([]byte, error)
"We don't need to change this method; using the default is the best."
"If you have changed func (p Param) MarshalJSON() ([]byte, error), then to implement the original functionality you'll need:

var propMap map[string]any
if err := json.Unmarshal(propData, &propMap); err != nil {
	return nil, err
}
return json.Marshal(propMap)

[otiai10]

I'm not sure why this required needs to be here. This required is supposed to contain all names of required params within this Params, not a Param. Could you give me more guidance here?

[otiai10]

Relatedly, do we need if p.Items != nil condition above?
If we don't need any special operation for array such as this required, I think omitempty for Items is enough.

[Naist4869]

I'm not sure why this required needs to be here. This required is supposed to contain all names of required params within this Params, not a Param. Could you give me more guidance here?我不确定为什么这个 required 需要在这里。这个 required 应该包含 Params 中 required 参数的所有名称，而不是 Param 。您能给我更多指导吗？

https://community.openai.com/t/how-to-calculate-the-tokens-when-using-function-call/266573/27
https://github.com/hmarr/openai-chat-tokens

  {
    messages: [{ role: "user", content: "hello" }],
    functions: [
      {
        name: "get_recipe",
        parameters: {
          type: "object",
          required: ["ingredients", "instructions", "time_to_cook"],
          properties: {
            ingredients: {
              type: "array",
              items: {
                type: "object",
                required: ["name", "unit", "amount"],
                properties: {
                  name: {
                    type: "string",
                  },
                  unit: {
                    enum: ["grams", "ml", "cups", "pieces", "teaspoons"],
                    type: "string",
                  },
                  amount: {
                    type: "number",
                  },
                },
              },
            },
            instructions: {
              type: "array",
              items: {
                type: "string",
              },
              description: "Steps to prepare the recipe (no numbering)",
            },
            time_to_cook: {
              type: "number",
              description: "Total time to prepare the recipe in minutes",
            },
          },
        },
      },
    ],
    tokens: 106,
  },

[Naist4869]

Relatedly, do we need if p.Items != nil condition above? If we don't need any special operation for array such as this required, I think omitempty for Items is enough.

This is just my coding habit. Using only 'if p.Type == "array"' is also acceptable

[otiai10]

When we have MarshalJSON of Param, we don't need this if-else switching but simply props[p.Name] = p, IMO.

[Naist4869]

It's Recursion

func (p *Param) MarshalJSON() ([]byte, error) {
    type Alias Param // Alias not impl  MarshalJSON, so not recursion
    return json.Marshal(&struct {
        *Alias
    }{
        Alias: (*Alias)(p),
    })
}

[Naist4869]

I tried what you suggested. Please help me verify.

[otiai10]

Now I've got your point. Thank you very much. I'll take time to look in.

[otiai10]

Thank you very much. I might add some change later but thank you for this great catch.