Rework line replace functionality to support empty strings #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@otkmnb2783 did you have any thoughts on this PR? |
|
@cball Thank you for the report. |
|
@otkmnb2783 should this branch be merged anytime soon ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, it was not possible to use this plugin to update an empty string value. We're using this on CI to set an
applicationIdSuffix, which is blank by default.Here are screenshots of a file updating a value with an empty string and a string with some characters in it in this branch:
Before running lane:
After running lane:
My hope was to also solve the case of updating integers, but the regex still needs a bit of tweaking for that to work. I have a test for this in the PR, but it is commented out.