Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVP System #335

Closed
Jonas21 opened this issue Dec 27, 2013 · 15 comments
Closed

PVP System #335

Jonas21 opened this issue Dec 27, 2013 · 15 comments
Labels
duplicate enhancement Increase or improvement in quality, value, or extent

Comments

@Jonas21
Copy link

Jonas21 commented Dec 27, 2013

TFS 1.0 not have the new pvp system of cipsoft.

We can make it?

Here:
http://tibia.wikia.com/wiki/Updates/10.0

@ronpetit
Copy link
Contributor

I want this too, but this is by your own editing the sources, what we can do is ask for help in how to do it, or maybe @marksamman will think in put that option in config.lua?

@Jonas21
Copy link
Author

Jonas21 commented Jan 2, 2014

Why no one answers?

@marksamman
Copy link
Member

Because no one is obliged to answer. If you want to code it, feel free to do so and submit a pull request. Make sure the current PVP system still can be used because not everyone is a fan of the new system.

@Jonas21
Copy link
Author

Jonas21 commented Jan 3, 2014

But @ronpetit have a good idea. We can add two system and add in config.lua "enable/disabled/".

@marksamman
Copy link
Member

That is an option, yes.

@ronpetit
Copy link
Contributor

ronpetit commented Jan 3, 2014

Yes, tha's an option, but as @marksamman said, to do that you have to code it, and i think that he don't have time, and i don't know how to do that :-(, if someone got it hhe/she can camke a pull request and we will be happy, but for now, everything that atleast i can do is ask for help, i really want to learn about C++

1 similar comment
@ronpetit
Copy link
Contributor

ronpetit commented Jan 3, 2014

Yes, tha's an option, but as @marksamman said, to do that you have to code it, and i think that he don't have time, and i don't know how to do that :-(, if someone got it hhe/she can camke a pull request and we will be happy, but for now, everything that atleast i can do is ask for help, i really want to learn about C++

@marksamman marksamman modified the milestone: 1.0 Mar 23, 2014
@WibbenZ
Copy link
Member

WibbenZ commented Apr 6, 2014

@marksamman has someone added this yet?

@marksamman
Copy link
Member

No. Open issues are yet to be addressed.
On Apr 6, 2014 1:02 PM, "WibbenZ" notifications@github.com wrote:

@marksamman https://github.com/marksamman has someone added this yet?

Reply to this email directly or view it on GitHubhttps://github.com//issues/335#issuecomment-39673553
.

@WibbenZ
Copy link
Member

WibbenZ commented Apr 8, 2014

Okay, but isent this a pretty big 'issue'? Its after all what cip has, its
not like we are asking for a rebirth system to be added to the source code.
But I do understand if you don't have time.
Den 8 apr 2014 03:13 skrev "Mark Samman" notifications@github.com:

No. Open issues are yet to be addressed.
On Apr 6, 2014 1:02 PM, "WibbenZ" notifications@github.com wrote:

@marksamman https://github.com/marksamman has someone added this yet?

Reply to this email directly or view it on GitHub<
#335 (comment)

.

Reply to this email directly or view it on GitHubhttps://github.com//issues/335#issuecomment-39802108
.

@marksamman
Copy link
Member

No, it's not a big issue. This project does not aim to replicate Tibia, the idea is that it should be customizable through Lua so that you can design your own PVP system.

@WibbenZ
Copy link
Member

WibbenZ commented Apr 8, 2014

Okay thanks, you got any time aspect at all? And are there any plans to add
a cast system to it?
Den 8 apr 2014 03:33 skrev "Mark Samman" notifications@github.com:

No, it's not a big issue. This project does not aim to replicate Tibia,
the idea is that it should be customizable through Lua so that you can
design your own PVP system.

Reply to this email directly or view it on GitHubhttps://github.com//issues/335#issuecomment-39803195
.

@marksamman
Copy link
Member

No. It might just as well never happen. We're open to pull requests though so if someone submits it tomorrow and the code is good enough it will be merged.

@WibbenZ
Copy link
Member

WibbenZ commented Apr 8, 2014

Okay thanks for the repons.
Den 8 apr 2014 03:40 skrev "Mark Samman" notifications@github.com:

No. It might just as well never happen. We're open to pull requests though
so if someone submits it tomorrow and the code is good enough it will be
merged.

Reply to this email directly or view it on GitHubhttps://github.com//issues/335#issuecomment-39803538
.

@marksamman
Copy link
Member

This will be customizable when #470 is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate enhancement Increase or improvement in quality, value, or extent
Projects
None yet
Development

No branches or pull requests

4 participants