Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in script bank.lua #3951

Closed
2 tasks done
luanluciano93 opened this issue Feb 16, 2022 · 4 comments · Fixed by #3955
Closed
2 tasks done

Error in script bank.lua #3951

luanluciano93 opened this issue Feb 16, 2022 · 4 comments · Fixed by #3955
Assignees
Labels
bug An issue describing unexpected behavior of code priority: medium

Comments

@luanluciano93
Copy link
Contributor

luanluciano93 commented Feb 16, 2022

Before creating an issue, please ensure:

  • This is a bug in the software that resides in this repository, and not a
    support matter (use https://otland.net/forums/support.16/ for support)
  • This issue is reproducible without changes to the C++ code in this repository

Steps to reproduce (include any configuration/script required to reproduce)

  1. hi, to NPC banker.
  2. transfer
  3. name that does not exist

Expected behaviour

reply that the player does not exist

Actual behaviour

image

Reproduction environment

https://github.com/otland/forgottenserver/blob/master/data/npc/scripts/bank.lua

@DSpeichert
Copy link
Member

You can paste images in GitHub.

@DSpeichert DSpeichert added the needs-triage Needs testing with screenshot/video confirmation label Feb 16, 2022
@EPuncker
Copy link
Contributor

EPuncker commented Feb 17, 2022

confirmed, error on both situations (char Luan Luciano doesn't exist):

00:12 Banker: Welcome to the bank, Perflex! Need some help with your bank account?
00:12 Perflex [1006]: transfer
00:12 Banker: Please tell me the amount of gold you would like to transfer.
00:12 Perflex [1006]: Luan Luciano

2022-02-17 00_14_09-The Forgotten Server

00:12 Perflex [1006]: transfer
00:12 Banker: Please tell me the amount of gold you would like to transfer.
00:12 Perflex [1006]: 100
00:12 Banker: Who would you like transfer 100 gold to?
00:13 Perflex [1006]: Luan Luciano

2022-02-17 00_14_42-The Forgotten Server

seems like someone didn't test this properly before (yes, that is me hehe)

@EPuncker EPuncker added bug An issue describing unexpected behavior of code priority: medium and removed needs-triage Needs testing with screenshot/video confirmation labels Feb 17, 2022
Znote added a commit to Znote/forgottenserver that referenced this issue Feb 18, 2022
@EPuncker EPuncker linked a pull request Feb 18, 2022 that will close this issue
3 tasks
@EPuncker
Copy link
Contributor

hey @luanluciano93 can you please test #3955 ?

@luanluciano93
Copy link
Contributor Author

Can check that way @Znote? https://pastebin.com/raw/zKNLKi7z

DSpeichert pushed a commit that referenced this issue Mar 12, 2022
Codinablack pushed a commit to Codinablack/forgottenserver that referenced this issue Apr 5, 2022
EPuncker pushed a commit to EPuncker/forgottenserver that referenced this issue May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue describing unexpected behavior of code priority: medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants