Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC not responding to message with "hi" (greetwords) in it #4397

Closed
2 tasks done
tornadia opened this issue Apr 9, 2023 · 2 comments · Fixed by #4398
Closed
2 tasks done

NPC not responding to message with "hi" (greetwords) in it #4397

tornadia opened this issue Apr 9, 2023 · 2 comments · Fixed by #4398
Labels
bug An issue describing unexpected behavior of code good first issue Issues that are easy to get started with priority: medium

Comments

@tornadia
Copy link
Contributor

tornadia commented Apr 9, 2023

As some of you know, after the introduction of Jiddo's NPC system, which greatly helped the community, there has been but one bad thing of it becoming a convoluted mess from keeping Mark's 10 year old codebase and re-introducing Jiddo's system. Some of the legacy code is still remaining within TFS, but unused at all.

I will describe a bug remnant from those changes.

Before creating an issue, please ensure:

  • This is a bug in the software that resides in this repository, and not a
    support matter (use https://otland.net/forums/otclient.494/ for support)
  • This issue is reproducible without changes to the code in this repository

Steps to reproduce (include any configuration/script required to reproduce)

  1. Say one of the greetwords to an npc.
    image
    image

  2. Say one of the keywords to the npc, it will work as expected.
    image

  3. If you say that keyword again, but include the word "hi", this time it will not work.
    image

  4. Or for a better illustrative example, include a word with "hi" inside of it.
    image

  5. See in the last example, using the words "pink" worked, but "white" didn't, because of the "hi" in "white".

Expected behaviour

Should process it in npcsystem

Actual behaviour

Doesn't

Proposed fix

image
image

Environment

Linux


I can submit a PR for it if needed. I believe this repository is abandoned, but I am informing you in case somebody else will find it relevant.

@EPuncker
Copy link
Contributor

EPuncker commented Apr 9, 2023

interesting

@tornadia
Copy link
Contributor Author

tornadia commented Apr 9, 2023

There, I made a PR: #4398

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue describing unexpected behavior of code good first issue Issues that are easy to get started with priority: medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants