NPC not responding to message with "hi" (greetwords) in it #4397
Labels
bug
An issue describing unexpected behavior of code
good first issue
Issues that are easy to get started with
priority: medium
As some of you know, after the introduction of Jiddo's NPC system, which greatly helped the community, there has been but one bad thing of it becoming a convoluted mess from keeping Mark's 10 year old codebase and re-introducing Jiddo's system. Some of the legacy code is still remaining within TFS, but unused at all.
I will describe a bug remnant from those changes.
Before creating an issue, please ensure:
support matter (use https://otland.net/forums/otclient.494/ for support)
Steps to reproduce (include any configuration/script required to reproduce)
Say one of the greetwords to an npc.
Say one of the keywords to the npc, it will work as expected.
If you say that keyword again, but include the word "hi", this time it will not work.
Or for a better illustrative example, include a word with "hi" inside of it.
See in the last example, using the words "pink" worked, but "white" didn't, because of the "hi" in "white".
Expected behaviour
Should process it in npcsystem
Actual behaviour
Doesn't
Proposed fix
Environment
Linux
I can submit a PR for it if needed. I believe this repository is abandoned, but I am informing you in case somebody else will find it relevant.
The text was updated successfully, but these errors were encountered: