Make player walkthrough optional #1301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -825,7 +825,7 @@ bool Player::canWalkthrough(const Creature* creature) const | |||
| } | |||
|
|
|||
| const Player* player = creature->getPlayer(); | |||
| if (!player) { | |||
| if (!player || g_config.getBoolean(ConfigManager::ALLOW_WALKTHROUGH)) { | |||
| return false; | |||
There was a problem hiding this comment.
Shouldn't be !g_config.getBoolean(ConfigManager::ALLOW_WALKTHROUGH)?
|
True that. Fixed. |
|
I feel like this should wait until move events are implemented. |
|
I agree with @EvanMC. |
|
I agree with @marksamman that agrees with @EvanMC |
|
No problem in leaving this PR open? :) |
| @@ -24,6 +24,7 @@ maxPlayers = 0 | |||
| motd = "Welcome to The Forgotten Server!" | |||
| onePlayerOnlinePerAccount = true | |||
| allowClones = false | |||
| allowWalkthrough = true | |||
There was a problem hiding this comment.
Shouldn't this be false by default? Sefaults should resemble vanilla in my opinion
There was a problem hiding this comment.
Nope, in Tibia players are walkthroughable by default. This is not a TFS-only feature, maybe you didn't know it has been implemented in Tibia :P
There was a problem hiding this comment.
WHAT? Oh hell no, sorry I got stuck in 7.4 apparently.
Sorry man
ranisalt
force-pushed
the
walkthrough-optional
branch
from
7a004ab
to
223fd3a
Compare
Fix inverted condition
ranisalt
force-pushed
the
walkthrough-optional
branch
from
223fd3a
to
5ff1c2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have just stumbled across this limitation, that the walkthrough could be optionally enabled at config.lua, and done the patch :)