Cast system #2007

Milice · 2016-11-24T15:26:10Z

Hopefully this cast system will be acceptable.

login12 · 2016-11-24T17:49:17Z

Awesome!!!!
Great job man!
Thanks alot for this contribute

login12 · 2016-11-24T18:14:16Z

if someone enter on cast this got name, spectator 1, and other ppl enter got name spectator2. But if spectator 1 leave and enter again, he got name spectator 2 too, resulting in 2 ppls with name spectator2.
^ because it i got crash.

If someone enter with specator 1 name... and get ban or something and other other ppl, then he enter like spectator 1 and CRASH.

solution: maybe put this for no reset, for spectator 1, and still counting spectator 1,2,3,4,5,... at cast restarts.

suggestion:
maybe count viewers on character list IN CAST, replace wordlist can be good.. ordering most viewers and less viewers
:)

djarek · 2016-11-24T18:35:27Z

src/protocolgame.cpp

+	}
+
+	if(command == "commands") {
+		player->sendChannelMessage("", "Available commands:", TALKTYPE_CHANNEL_O, CHANNEL_CAST, false);


Data race on the player object.

Thank you for pointing this out, do you have any tip on how i SHOULD handle these things to not data race? Thank you.

The rule is that most (if not all) parse* functions are run in the networking thread. You would either need to add some kind of synchronization mechanism to Player (e.g. mutex) or run a function in the dispatcher.

djarek · 2016-11-24T18:37:54Z

src/protocolspectator.cpp

+			if(recvbyte == 0x64) {
+				sendCancelWalk();
+			}
+			sendMoveCreature(player, player->getPosition(), player->getTile()->getStackposOfCreature(spectator, player->getCreature()), player->getPosition(), player->getTile()->getStackposOfCreature(spectator, player->getCreature()), false);


Data race on the player object.

djarek · 2016-11-24T18:44:51Z

src/player.h

@@ -105,7 +105,7 @@ struct Skill {

 typedef std::map<uint32_t, uint32_t> MuteCountMap;

-static constexpr int32_t PLAYER_MAX_SPEED = 1500;
+static constexpr int32_t PLAYER_MAX_SPEED = 5000;


Fixing this, forgot to revert from my local test.

djarek · 2016-11-24T18:53:22Z

src/player.h

@@ -1260,6 +1300,7 @@ class Player final : public Creature, public Cylinder
 		int32_t offlineTrainingSkill = -1;
 		int32_t offlineTrainingTime = 0;
 		int32_t idleTime = 0;
+		uint32_t spectatorCount = 0;


What's the point of this variable?

Variable removed. Thank you for pointing this out.

djarek · 2016-11-24T18:57:29Z

src/player.h

@@ -1182,6 +1218,9 @@ class Player final : public Creature, public Cylinder
 		std::map<uint32_t, int32_t> storageMap;

 		std::vector<OutfitEntry> outfits;
+		std::vector<ProtocolSpectator*> spectators;


Storing raw pointers to objects managed by shared_ptr is a bad idea IMO.

Modified to store a shared_ptr, thanks.

djarek · 2016-11-24T18:58:18Z

src/protocolgame.cpp

@@ -865,6 +1003,20 @@ void ProtocolGame::parseSay(NetworkMessage& msg)
 		return;
 	}

+	if(channelId == CHANNEL_CAST && player->isLiveCasting()) {
+		InstantSpell* instantSpell = g_spells->getInstantSpell(text);


Data race on g_spells.

djarek · 2016-11-24T18:58:39Z

src/protocolgame.cpp

@@ -865,6 +1003,20 @@ void ProtocolGame::parseSay(NetworkMessage& msg)
 		return;
 	}

+	if(channelId == CHANNEL_CAST && player->isLiveCasting()) {


Data race on the player object.

djarek · 2016-11-24T19:01:58Z

src/protocolspectator.cpp

+			player->sendChannelMessage("", ss.str(), TALKTYPE_CHANNEL_O, CHANNEL_CAST);
+		}
+		spectator->client.reset();
+		spectator = nullptr;


Memory leak of spectator?

totolol123 · 2016-11-24T20:21:29Z

What is the differences related to @djarek cast system?

login12 · 2016-12-10T00:39:03Z

any progress? bugs has been fixeds?

DamianDEB · 2016-12-10T16:16:17Z

login12
better ways use otx with works cast and some new system like a unjustified frags window
minimal work fix and have good engine tfs is so far to be good
https://github.com/mattyx14/otxserver/tree/otxserv3/path_10_9

Fouad90 · 2016-12-20T08:49:41Z

src/player.cpp

+	Database* db = Database::getInstance();
+
+	std::ostringstream query;
+	query << "UPDATE `players_online` SET `cast_password` = '" << db->escapeString(password) << "' WHERE `player_id` = '" << getGUID() <<"';";


If I am not wrong, you should change:
cast_password = '" << db->escapeString(password) << "'
to:
cast_password = " << db->escapeString(password) << "
Getting SQL errors when I use a password.

yes in !cast (password) get error in console in !cast and connect to spect get debug and crash server this code its crappy ...

CREATE TABLE IF NOT EXISTS players_online (
player_id int(11) NOT NULL,
cast_password varchar(30) DEFAULT NULL,
cast_spectators smallint(5) NOT NULL DEFAULT '0',
PRIMARY KEY (player_id)
) ENGINE=MEMORY;

missing " , "

Cjaker · 2016-12-28T11:46:03Z

I found a problem, if u enter in cast with 2+ ppl and u have monsters/creatures in screen he debug.

(i think is anything type move creature idk).

DamianDEB · 2016-12-30T18:50:01Z

Eternal-Scripts on tfs 1,2 or 1,3? on my 1.2 this system crash after spec connect to caster

Fluppix · 2017-01-05T08:48:11Z

Working good with normal client but cause crash if I login as spectator with OTClient. Anyone can confirm this?

MatheusGrilo · 2017-03-20T07:58:47Z

I don't know if you are still working on this, but:
1st open a live cast;
2nd enter in this cast as spectator;
3rd close the client of spectator (X button).

TFS Crash.

Cast system

994519f

Hopefully this cast system will be acceptable.

djarek requested changes Nov 24, 2016

View reviewed changes

marksamman mentioned this pull request Nov 26, 2016

Casting system #994

Closed

Fouad90 reviewed Dec 20, 2016

View reviewed changes

WibbenZ closed this Dec 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cast system #2007

Cast system #2007

Milice commented Nov 24, 2016

login12 commented Nov 24, 2016 •

edited

login12 commented Nov 24, 2016 •

edited

djarek Nov 24, 2016

Milice Nov 24, 2016

djarek Nov 24, 2016

djarek Nov 24, 2016

djarek Nov 24, 2016

Milice Nov 24, 2016

djarek Nov 24, 2016

Milice Nov 24, 2016

djarek Nov 24, 2016

Milice Nov 24, 2016

djarek Nov 24, 2016

djarek Nov 24, 2016

djarek Nov 24, 2016

totolol123 commented Nov 24, 2016

login12 commented Dec 10, 2016

DamianDEB commented Dec 10, 2016

Fouad90 Dec 20, 2016

DamianDEB Dec 27, 2016 •

edited

Cjaker commented Dec 28, 2016

DamianDEB commented Dec 30, 2016

Fluppix commented Jan 5, 2017

MatheusGrilo commented Mar 20, 2017 •

edited

Cast system #2007

Cast system #2007

Conversation

Milice commented Nov 24, 2016

login12 commented Nov 24, 2016 • edited

login12 commented Nov 24, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

totolol123 commented Nov 24, 2016

login12 commented Dec 10, 2016

DamianDEB commented Dec 10, 2016

Choose a reason for hiding this comment

DamianDEB Dec 27, 2016 • edited

Choose a reason for hiding this comment

Cjaker commented Dec 28, 2016

DamianDEB commented Dec 30, 2016

Fluppix commented Jan 5, 2017

MatheusGrilo commented Mar 20, 2017 • edited

login12 commented Nov 24, 2016 •

edited

login12 commented Nov 24, 2016 •

edited

DamianDEB Dec 27, 2016 •

edited

MatheusGrilo commented Mar 20, 2017 •

edited