Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple delete called on condition in Lua #2325

Merged
merged 1 commit into from
Sep 9, 2017
Merged

Fix multiple delete called on condition in Lua #2325

merged 1 commit into from
Sep 9, 2017

Conversation

DanielChabrowski
Copy link
Contributor

Fixing #2320

@djarek djarek added the bugfix label Sep 6, 2017
djarek
djarek approved these changes Sep 6, 2017
View reviewed changes
Copy link
Contributor

@djarek djarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ranisalt
Copy link
Member

ranisalt commented Sep 9, 2017

Good one! I'd still use vector though.

@ranisalt ranisalt merged commit 674595e into otland:master Sep 9, 2017
@DanielChabrowski DanielChabrowski deleted the fix_multiple_delete_condition branch September 9, 2017 21:06
@djarek djarek added this to the 1.3 milestone Sep 10, 2017
@djarek djarek added this to Done in TFS 1.4 Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djarek djarek djarek approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
No open projects
TFS 1.4
Done
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielChabrowski @ranisalt @djarek