otserv.cpp: Tidy and comment otserv #2685
Conversation
foxrother
changed the title
| std::cout << ">> Loading vocations" << std::endl; | ||
| if (!g_vocations.loadFromXml()) { | ||
| startupErrorMessage("Unable to load vocations!"); | ||
| return; | ||
| } | ||
|
|
||
| // load item data | ||
| // TODO DOC |
There was a problem hiding this comment.
Stripping comment in favor of a placeholder comment?
Shouldn't the todo list be resolved before you commit a PR? Especially if each PR represent a file/section already.
There was a problem hiding this comment.
Hey! Thanks for giving your feedback.
The stripped comment states the obvious and does not provide any additional insight.
I marked those as "TODO" because I wanted contributors (including myself) to know what are the parts that can receive more attention (including my own).
Also, would you leave a comment on something that you don't fully understand? I'd rather mark it.
I mentioned in the forums that I'm focusing on the more fundamental parts of the code base right now.
I intend to update those comments as I read their respective files, I simply can't do it in a heartbeat...
|
I hope I haven't startled anyone. 😛 I'd also like to say that I'm not "moving lines around" for stats' sake. |
Code tidying and extensive commenting.