Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify monsters that summon appears #2841

Merged
merged 3 commits into from May 1, 2020

Conversation

nekiro
Copy link
Member

@nekiro nekiro commented Mar 15, 2020

Fix #2235

@WibbenZ
Copy link
Member

WibbenZ commented Mar 15, 2020

Haven't tested it, but if you ask me it would be better to add this to C++ since we (and other datapacks) call the x:addSummon() / setMaster functions in other scripts.

@nekiro
Copy link
Member Author

nekiro commented Mar 15, 2020

@WibbenZ then we should add it to addSummon method (its in lua)

@WibbenZ
Copy link
Member

WibbenZ commented Mar 15, 2020

My mistake and in that case, yes we should add it there.
In these cases it's better to fix it at the source of a function rather than adding small fixes in all the codes we have(not to mention backwards compatibility).

If the rest disagrees with me you would have to fix it in these cases aswell: https://github.com/otland/forgottenserver/search?q=addSummon&unscoped_q=addSummon

@Leo32onGIT Leo32onGIT mentioned this pull request Mar 16, 2020
@Leo32onGIT
Copy link
Contributor

The only situations that trigger this, is when users on GOD characters are summoning monsters and trying to mess with players.

If you're doing that, who cares if monster are idle or 'dance' near you, plus it means you've already messed with groups.xml - so maybe this is appropriate?

#2848 (comment)

@nekiro
Copy link
Member Author

nekiro commented Mar 16, 2020

@Leo32onGIT it was done like that before anyway (when was in sources), so that should be there imo

@nekiro nekiro added the bugfix label Apr 27, 2020
@DSpeichert DSpeichert merged commit c614a3c into otland:master May 1, 2020
@nekiro nekiro deleted the fix-notify-monsters branch May 1, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in new setMaster behavior
4 participants