Fix trade stacking items #3248
Merged
Fix trade stacking items #3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, I have noticed inconsistencies, when moving articles in which several cylinders must be verified, this could be the cause, but I will still review it more thoroughly, and do tests |
DSpeichert
approved these changes
Feb 6, 2022
|
@MillhioreBT any news on tests? |
EPuncker
approved these changes
Feb 8, 2022
Znote
pushed a commit
to Znote/forgottenserver
that referenced
this pull request
Feb 23, 2022
DSpeichert
pushed a commit
that referenced
this pull request
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure why this code is there, but this breaks passing FLAG_IGNOREAUTOSTACK (and probably other flags too) for trading and any other internalMoveItem that is not moved in single queryDestination execute.
I think it's probably, because Tile::queryDestination can add "FLAG_NOLIMIT" to flags
Here is the explanation behind this "flags = 0;" code
In trade item is moved to player, so it queries two cylinders, first one is player, second one is his backpack to which item is moved, querying player deletes flag "flags = 0", so second query stacks the item, because flags is 0 at this point and it merges two same stackable items in trade which results in whole stack on one side.