Skull system

[rookgaard]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Introduced skull system described in https://tibia.fandom.com/wiki/Skull_System

[rookgaard]

@EPuncker Can you add reviewers?

[MillhioreBT]

Please use the new string formatting style fmt

[rookgaard]

@MillhioreBT Where do you want me to use that formatting?

[MillhioreBT]

@MillhioreBT Where do you want me to use that formatting?

Sorry for not specifically suggesting where
In everything that makes use of: std::ostringstream

This is suggested in the PR #3351, apparently the idea is to get rid of the use of std::ostringstream and using fmt instead

[rookgaard]

@MillhioreBT In my opinion, as long as there are usages of ostringstream inside that file, we shouldn't mix up different approaches. There should be a separate PR to replace all uses to fmt in iologindata.cpp.

[ranisalt]

I would rather have the control be done in Lua instead, but I consider it an improvement over the current situation.

[MillhioreBT]

I would rather have the control be done in Lua instead, but I consider it an improvement over the current situation.

I also support the idea of ​​handling this in lua, as this seems to be a feature that anyone would want to manipulate for their own purposes and modifications ;), but as rani says, this is fine in any case

[nekiro]

It actually shouldn't be hard to move to lua, it's bunch of queries and some logic and we have ondeath/onpreparedeath/onkill events, so you can slap skull system there easily. Honestly I don't see any limitations to make this in lua.

[EPuncker]

Lets leave the Lua part to another PR shall we? 😛 I'm in favor of this change as it is an improvement of the current one

[rookgaard]

@nekiro @DSpeichert

[Znote]

I must admit I like the OT skull system more, I have had lots of fun on some custom rpg styled pvp servers that had like a constant 2-4 hour to loose 1 frag, without any daily/weekly/monthly limits. As it opens up for the possibility to kill lots of people daily without getting red/black skull, while still preventing "mass pk incidents" where someone would slay all lowbies in the area.

So I think you should re-implement the previous behavior as an optional toggle in config that just uses timeToDecreaseFrags. Retain "backwards compatibility" with skull system, perhaps we can call it oldOTSkullSystem = bool
Instead of fixed red/black skull duration, make the duration be based on remaining frags (when you have 0 frags, you loose red/black skull).

If I have 2 hour to decrease frag, how would I do it with this new skull system? Go 24 hour (daily limit) / 2 = 12 frags to red skull, set weekly and monthly to 9000+ to avoid those calculations. The risk is here that someone will spam UE and kill 12 people right off the bat, whereas with the retro OT skull system they had to "space out" their killing spree throughout the day. (Since they would get red skull after 3 kills, but are relatively quickly loosing frags).

[EPuncker]

@DSpeichert I rebased it and solved conflicts.

[yamaken93]

As far i understand this orange skull check here does not make sense. The orange skull must be checked on the attacked player (the player which has been killed) and its a "client skull" (a skull that only appear to you at certain conditions like yellow skull, party skull, warmode skull etc) manipulated by the Creature::getSkullClient function.

[pasturryx]

when merged is going to be added?

[ranisalt]

I believe this system can be implemented in Lua. When a player is killed by another, recalculate the skull; using a storage value to keep track of skull duration and an event to clear it if the player is online when it expires, or check on login. We already have skull functions in Lua.