Use shared_ptr for depot locker and depot chests #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Simply perfect and a way forward to change all pointers to smart |
ranisalt
reviewed
Apr 22, 2021
EvilHero90
approved these changes
Apr 23, 2021
EPuncker
approved these changes
Apr 23, 2021
ranisalt
approved these changes
Apr 23, 2021
|
Why is the pipeline failing though? |
It's some vcpkg thing that fails, code compiled fine cause I tested the compilation at least xD |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix memory leak pointed out in #3346
I didn't test this code, so testing is welcome!