Update fluids.lua #3501
Merged
Update fluids.lua #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using an empty fluid container on a filled container would make them both empty containers. The script should copy the fluid type from the target container before transforming the target container to en empty one. It was doing the reverse: transforming en empty one, then copying no fluid type
MillhioreBT
approved these changes
Jul 16, 2021
EPuncker
approved these changes
Jul 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
change order between 2 lines of code
Issue addressed
Using an empty fluid container on a filled container would make them both empty containers.
The script should copy the fluid type from the target container before transforming the target container to en empty one.
It was doing the reverse: transforming an empty one, then copying no fluid type