Remove condition by Condition parameters (fixes #3544)

[Erza]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

A copy of the Condition object was added to the creature in LuaScriptInterface::luaCreatureAddCondition, therefore Creature::removeCondition could not remove the condition properly, as the Condition object that was constructed from Userdata did not match the one stored in the creature's condition list.

Also applied const correctness.

Issues addressed: closes #3544

[MillhioreBT]

If you use logic, you will realize that this PR does not make any sense

This function has two behaviors:

• Remove by userdata: this gives us to understand that we need to pass the correct user data stored in the player conditions, if you pass a random or self-generated condition then it is very obvious that it will not remove anything since you random condition is not a player condition

• Remove by type: this is the behavior of a lifetime, you specify the search parameters, and if these parameters match any condition stored in the player then we obtain this condition and eliminate it

¿How to use the function correctly with userdata?

creature:removeCondition(creature:getCondition(...), ...)

If you still insist, you can add an overload in lua and it looks much better, although counterintuitive and can lead people to think incorrectly, it is already out of basic logic.

[Erza]

If you use logic, you will realize that this PR does not make any sense

This function has two behaviors:

• Remove by userdata: this gives us to understand that we need to pass the correct user data stored in the player conditions, if you pass a random or self-generated condition then it is very obvious that it will not remove anything since you random condition is not a player condition
• Remove by type: this is the behavior of a lifetime, you specify the search parameters, and if these parameters match any condition stored in the player then we obtain this condition and eliminate it

¿How to use the function correctly with userdata?

creature:removeCondition(creature:getCondition(...), ...)

If you still insist, you can add an overload in lua and it looks much better, although counterintuitive and can lead people to think incorrectly, it is already out of basic logic.

Read #3544 (comment)

[MillhioreBT]

If you use logic, you will realize that this PR does not make any sense
This function has two behaviors:

• Remove by userdata: this gives us to understand that we need to pass the correct user data stored in the player conditions, if you pass a random or self-generated condition then it is very obvious that it will not remove anything since you random condition is not a player condition
• Remove by type: this is the behavior of a lifetime, you specify the search parameters, and if these parameters match any condition stored in the player then we obtain this condition and eliminate it

¿How to use the function correctly with userdata?

creature:removeCondition(creature:getCondition(...), ...)

If you still insist, you can add an overload in lua and it looks much better, although counterintuitive and can lead people to think incorrectly, it is already out of basic logic.

Read #3544 (comment)

And I understand what you mean by using a condition and then extracting its properties and then finding the player's condition and so bla bla bla
I thought about this first than you, before this feature was added, but then I realized that it is just an additional complication
For example, what happens if we pass the correct user data? in this case we have to look for it again and it is like a pretty silly code

In case you are too lazy to write 20 more letters you can do a help function:
data/lib/core/condition.lua

function Condition:unpack()
	return self:getType(), self:getId(), self:getSubId()
end

script.lua

-- force: default
creature:removeCondition(condition:unpack())
-- force: false
creature:removeCondition(condition:unpack(), false)
-- force: true
creature:removeCondition(condition:unpack(), true)

[DSpeichert]

I'm not entirely against it, although we may be requiring in other places the Lua developer to also pass actual condition, not a replica. This behavior does not hurt though.

[Codinablack]

All checks passing, all reviews passing. LGTM

PR is from 2021, its amazing its still able to be merged... Can we do so now?