Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getDirectionTo method #3645

Merged
merged 1 commit into from Sep 14, 2021
Merged

Fix getDirectionTo method #3645

merged 1 commit into from Sep 14, 2021

Conversation

nekiro
Copy link
Member

@nekiro nekiro commented Sep 14, 2021

This pull request fixes getDirectionTo helper method, which returns some weird direction instead of none if from == to.

By the way it also fixes #3643

Zbizu
Zbizu approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@Zbizu Zbizu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the issue while also fixes getDirectionTo.

Has potential to break something that was relying on frompos=topos -> nw in the future, but we can change things to mind the correct implementation later.

@EPuncker EPuncker merged commit 11a4a5e into master Sep 14, 2021
@EPuncker EPuncker deleted the nekiro-patch-1 branch September 14, 2021 19:22
@Zbizu Zbizu mentioned this pull request Sep 14, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EPuncker EPuncker EPuncker approved these changes

@Zbizu Zbizu Zbizu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ultimate spells area bug
3 participants
@nekiro @EPuncker @Zbizu