Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ring attribute for monster spells #3691

Merged
merged 1 commit into from
Sep 25, 2021

Conversation

soul4soul
Copy link
Contributor

@soul4soul soul4soul commented Sep 25, 2021

Pull Request Prelude

Changes Proposed

While I really don't like the creature spell system and think it should be deprecated in favor of revscriptsys spells + revscriptsys monsters it was easy and convenient to make a ring attribute to support spells for the tibia monsters which have a ring shaped attack.

XML
<attack name="fire" interval="1000" chance="100" ring="2" target="0" min="-1" max="-2">
			<attribute key="shootEffect" value="fire" />
			<attribute key="areaEffect" value="firearea" />
		</attack>

LUA
monster.attacks = {
	{name = "combat", type = COMBAT_LIFEDRAIN, chance = 100, interval = 1000, ring = 4, target = true, minDamage = -1, maxDamage = -1, effect = CONST_ME_PURPLEENERGY}
}

I made ring=2 a cross because that is another common shape and radius=2 is already a plus shape and radius=3 is already an exori shape. With this addition we cover all the spell shapes used on tibiawiki.

Test with both XML and revscriptsys
riing2
ring3
ring4

@omarcopires
Copy link
Contributor

Very good! Could you also add the spread?

@EPuncker EPuncker added the feature New feature or functionality label Sep 25, 2021
@EPuncker EPuncker merged commit aa76e5c into otland:master Sep 25, 2021
@soul4soul
Copy link
Contributor Author

Very good! Could you also add the spread?

What spread?

The ring attribute works just like radius so it can be used on self or on target with an optional range.

@EPuncker
Copy link
Contributor

Very good! Could you also add the spread?

What spread?

The ring attribute works just like radius so it can be used on self or on target with an optional range.

I think he means that effect that most of new monsters are using, their draw a line of effect to the player and anything between it takes damage

@EPuncker
Copy link
Contributor

also seems like it can target multiple players:
2021-09-25 19_01_26-(3) Tibia #375- HUNT Aparições Dark Thais- Mirrored Nightmare - (STREAMER Nawtsc
https://youtu.be/36w6sr24Z_M?t=2032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants