Create ring attribute for monster spells #3691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
While I really don't like the creature spell system and think it should be deprecated in favor of revscriptsys spells + revscriptsys monsters it was easy and convenient to make a ring attribute to support spells for the tibia monsters which have a ring shaped attack.
I made ring=2 a cross because that is another common shape and radius=2 is already a plus shape and radius=3 is already an exori shape. With this addition we cover all the spell shapes used on tibiawiki.
Test with both XML and revscriptsys
![riing2](https://user-images.githubusercontent.com/5142635/134775421-888de26b-2b09-4796-a56f-106940ec811b.PNG)
![ring3](https://user-images.githubusercontent.com/5142635/134775422-15f36feb-8a13-4d2e-be8a-ddefe9cecd0c.PNG)
![ring4](https://user-images.githubusercontent.com/5142635/134775424-6777730c-63b1-471f-9c83-fb4b12611dc9.PNG)