Add missing message to warn the player that he can't accept his own offer #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EPuncker
approved these changes
Sep 29, 2021
|
cip's |
DSpeichert
requested changes
Oct 4, 2021
EPuncker
changed the title
EPuncker
previously approved these changes
Oct 7, 2021
EPuncker
reviewed
Oct 7, 2021
EPuncker
previously approved these changes
Oct 7, 2021
|
I believe it is now okay to be added, except that the version check can be removed. |
EPuncker
reviewed
Dec 13, 2021
|
Been having that line (without version check) in my repo and reworked market three times already (so it got plenty of testing). Didn't had any problems with it. Remove version check and it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Added missing message to warn the player that he can't accept his own offer
Issues addressed: