Use single list as waiting queue #3712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranisalt
force-pushed
the
waitlist-single-queue
branch
from
e297530
to
5a7964e
Compare
|
OMG I love how you write code in C++ 🤗 |
EPuncker
approved these changes
Oct 11, 2021
EPuncker
requested changes
Oct 11, 2021
ranisalt
changed the title
ranisalt
force-pushed
the
waitlist-single-queue
branch
from
1f428ec
to
fd1f0ca
Compare
ranisalt
force-pushed
the
waitlist-single-queue
branch
from
fd1f0ca
to
4d10d59
Compare
|
Fixed the infinite loading issue |
EPuncker
previously approved these changes
Feb 16, 2022
ranisalt
changed the title
DSpeichert
previously approved these changes
Feb 16, 2022
EPuncker
previously approved these changes
Feb 17, 2022
ranisalt
force-pushed
the
waitlist-single-queue
branch
from
8577d94
to
746a29c
Compare
EPuncker
approved these changes
Mar 9, 2022
Codinablack
pushed a commit
to Codinablack/forgottenserver
that referenced
this pull request
Apr 5, 2022
(cherry picked from commit 1df7090)
EPuncker
pushed a commit
to EPuncker/forgottenserver
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Replaces the pair of queues (priority waitlist + standard waitlist) with a single list, keeping a token to the boundary. Reduces code complexity for calculating the length and finding a new slot.
Issues addressed:
None