Fix memory leak on luaPlayerShowTextDialog - double ref

[ramon-bernardo]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

• Fix memory leak on luaPlayerShowTextDialog - double ref

• Player::setWriteItem and Item::CreateItem will add reference so we'll end up with 2 references and since we'll have 2 references the memory allocated will never be destroyed.

[Zbizu]

wasn't there some way to check if item is virtual? Could save effort setting all those variables.

[MillhioreBT]

I agree, however those booleans look a bit ugly, you should find some more beautiful way to fix that problem, maybe smart pointers.

Maybe add a new argument to the method setWriteItem
Example:

void Player::setWriteItem(Item* item, uint16_t maxWriteLen /*= 0*/, bool addRef /*= true*/)

Then:

Example

int LuaScriptInterface::luaPlayerShowTextDialog(lua_State* L)
{
	// player:showTextDialog(id or name or userdata[, text[, canWrite[, length]]])
	Player* player = getUserdata<Player>(L, 1);
	if (!player) {
		lua_pushnil(L);
		return 1;
	}

	int32_t length = getNumber<int32_t>(L, 5, -1);
	bool canWrite = getBoolean(L, 4, false);
	std::string text;

	int parameters = lua_gettop(L);
	if (parameters >= 3) {
		text = getString(L, 3);
	}
      
	Item* item;
        bool addRef = true;
	if (isNumber(L, 2)) {
		item = Item::CreateItem(getNumber<uint16_t>(L, 2));
	} else if (isString(L, 2)) {
		item = Item::CreateItem(Item::items.getItemIdByName(getString(L, 2)));
	} else if (isUserdata(L, 2)) {
		if (getUserdataType(L, 2) != LuaData_Item) {
			pushBoolean(L, false);
			return 1;
		}

		item = getUserdata<Item>(L, 2);
                addRef = false;
	} else {
		item = nullptr;
	}

	if (!item) {
		reportErrorFunc(L, getErrorDesc(LUA_ERROR_ITEM_NOT_FOUND));
		pushBoolean(L, false);
		return 1;
	}

	if (length < 0) {
		length = Item::items[item->getID()].maxTextLen;
	}

	if (!text.empty()) {
		item->setText(text);
		length = std::max<int32_t>(text.size(), length);
	}

	item->setParent(player);
	player->setWriteItem(item, length, addRef);
	player->sendTextWindow(item, length, canWrite);
	pushBoolean(L, true);
	return 1;
}

The idea is of @nekiro but I like it