Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 12.71 update (second attempt) #3784

Closed
wants to merge 7 commits into from
Closed

Conversation

EPuncker
Copy link
Contributor

@EPuncker EPuncker commented Nov 8, 2021

all credits and everything else is on #3748

feel free to edit description/title as your liking

this is my attempt, I got it in 5 commits

EPuncker and others added 5 commits November 8, 2021 12:53
- new mounts
- new outfits
- new items.xml entries
- new items.otb
- migration/schema for mount colors
- compatibility stuff

Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
nekiro
nekiro previously approved these changes Nov 8, 2021
Copy link
Contributor

@Zbizu Zbizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit names are not descriptive enough. "stuff" doesn't tell anything about what was added. The branch name is unacceptable. I won't allow a full week of 16 hour sessions worth of programming being merged as "cringe".

@EPuncker
Copy link
Contributor Author

EPuncker commented Nov 9, 2021

for the otcrashbr members who were stupid (not to say other thing hehe) enough to thumb down this PR I'll give the context:

this was made in order for other people in discord (that are willing to git rebase the original PR) to have an idea on how to group the commits, it is not intended to be merged...

btw @dudantas

nice work bro, keep it up! https://i.imgur.com/JHxsIEy.png

if you guys have anything to say to me, you know where to find me 😃 lets keep github clean

@otland otland locked as too heated and limited conversation to collaborators Nov 9, 2021
@EPuncker EPuncker closed this Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants