Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3768 - Fixing use of item on the house door #3786

Merged
merged 5 commits into from
Nov 15, 2021
Merged

#3768 - Fixing use of item on the house door #3786

merged 5 commits into from
Nov 15, 2021

Conversation

ArturKnopik
Copy link
Contributor

#3768 - Fixing use of item on the house door

Pull Request Prelude

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

@marmichalski
Copy link
Contributor

marmichalski commented Nov 13, 2021 •
edited
Loading

This is not only house door but also "shop-like" houses where walls are counters. Anyway, that's nitpicking, but shouldn't that feature be somehow dependant of ONLY_INVITED_CAN_MOVE_HOUSE_ITEMS config option? And maybe that option should be renamed to something more universal? Or maybe this feature should have it's own flag. Having it enable and non-configurable is not a way to go, IMHO.

marmichalski
marmichalski reviewed Nov 13, 2021
View reviewed changes
src/actions.cpp Outdated Show resolved Hide resolved
@ArturKnopik @marmichalski
Update src/actions.cpp
e870183 
add suggested change

Co-authored-by: Marcin Michalski <evulmastah@gmail.com>
nekiro
nekiro requested changes Nov 14, 2021
View reviewed changes
src/actions.cpp Outdated Show resolved Hide resolved
@ArturKnopik @nekiro
Update src/actions.cpp
f0b7ffb 
fix items use in house door - Nekiro suggestion

Co-authored-by: nekiro <nekiro.dev@gmail.com>
@EPuncker
Copy link
Contributor

tabbing seems to be off by 1 from the rest of the code, other than that, looks good

@EPuncker EPuncker requested a review from nekiro November 15, 2021 01:52
@nekiro
Copy link
Member

nekiro commented Nov 15, 2021

tabbing seems to be off by 1 from the rest of the code, other than that, looks good

Might be, my tabbing skills in www github are bad xD

@ArturKnopik
Copy link
Contributor Author

cleaned

@EPuncker EPuncker merged commit f409cec into otland:master Nov 15, 2021
@ArturKnopik ArturKnopik deleted the fixHouseContainer branch November 18, 2021 11:59
Znote pushed a commit to Znote/forgottenserver that referenced this pull request Jan 30, 2022
@ArturKnopik @Znote
otland#3768 - Fixing use of item on the house door (otland#3786)
7e8ab9e
DSpeichert pushed a commit that referenced this pull request May 9, 2022
@ArturKnopik @DSpeichert
#3768 - Fixing use of item on the house door (#3786)
54e54c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marmichalski marmichalski marmichalski left review comments

@EPuncker EPuncker EPuncker approved these changes

@nekiro nekiro nekiro approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ArturKnopik @marmichalski @EPuncker @nekiro